-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add workflow to approve pr runs #11416
Conversation
Signed-off-by: Humair Khan <[email protected]>
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
This is a workflow that, when a user comments on a pr it will do the following:
/ok-to-test
it will:/ok-to-test
on an issue, then the workflow fails silentlyThe workflow is written to be extendible to other commands as the need arises. It's a very simple workflow, and in the future we may want a better alternative but this will at least remove the bottle neck on maintainers to approve workflow runs, and once again allow members to do this.