fix(sdk): Add error handling. Fixes #11164 #11356
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @Yael-F. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Thank you @Yael-F.
I just left a minor suggestion.
Also, can you:
/ok-to-test
Signed-off-by: Yael <[email protected]>
Yael-F
force-pushed
the
fix/sdk_component_build
branch
from
df7e1c1
to
f55ebe9
Compare
|
/lgtm |
github-actions
bot
added
the
ci-passed
|
@Yael-F thank you, apologies for the wait this lgtm, I was able to test and confirm this addresses the original issue can you rebase your PR and also add these changes to: https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md#bug-fixes-and-other-changes happy to approve once done! |
Description of your changes:
Fixes #11164 by adding error handling for image build/push failures in the KFP SDK. Now, errors trigger a clear error message and a non-zero exit code, ensuring accurate feedback to users.
Checklist: