-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emissary Executor feedback #6249
Comments
If you have already tried emissary executor:
|
Hello @Bogby, I am trying out the emmisary executor with Argo workflows. It appears that simply applying a configmap specifying the emmisary executor is sufficient to break Argo. After application, the workflow will launch, but pods do not initialize. Has anyone else experienced this issue or can you tell me what am I doing wrong? my configmap
I am testing two different workflows in the default and argo namespaces
|
Hi @wdma, thank you for trying out! Yes, when updating the config argo will behave in a completely different mode. If you hit issues, we can help you investigate. Can you report a separate issue with more details? E.g. can you copy all logs/events for a Pod that do not start? |
Hi @Bobgy Thank you for your response. I have been working through a range of issues on the Argo Github site. They have been very helpful and I have emissary working for the most part. Can you tell me if this (latest) issue might be related to emissary (argoproj/argo-workflows#6942)? If so, I would greatly appreciate your insights. If not, you can go ahead and close this as I think I am now past my issues with the emissary executor :) |
I can report for a team of 10 data scientists that all pipelines in v1 mode work with runasnonroot. I think you should make it the default. |
@Bogby can you tell me if some setting in emissary might be the cause of my current problem? I can now successfully execute a workflow, but I have no control over the serviceaccount and the permissions for whichever serviceaccount is used are insuffucient. I have described the problem in detail here https://stackoverflow.com/questions/69607918/serviceaccount-name-does-not-stick In short,I think this may be two problems (permissions issue and the service account issue), but I am not certain where to start teasing these two out. I like the fact that I can runasnonroot and just want it to work! |
Just give default-editor (or whatever service account you are using the necessary permissions) a full Kubeflow install does this by default. Since you are using Argo directly without the kubeflow pipelines SDK you are in the wrong GitHub project. |
@juliusvonkohout thank you for your response. I have solved this problem. Will note the project in the future! |
@Bobgy Argo itself will make it the default in argo>=3.3. according to https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary |
Thanks for the FYI, it's good to see that we are making the same choice! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
#7986 Trying to convert docx to pdf with libreoffice. it fails there. |
This may be relevant here: #9292. Seems to be a bug related to background processes in emissary that is fixed in the latest Argo. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/close emissary is the only executor still supported |
@juliusvonkohout: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@rimolive if there are any PNS or so leftovers we have to get rid of them. Newer Argo only supports emissary. |
did you mean leftovers in the code, or PRs, issues, or all of that? |
All three areas can be cleaned up. In the code I only found one file so far that contained PNS. |
Part of #5718
Emissary Executor Documentation: https://www.kubeflow.org/docs/components/pipelines/installation/choose-executor/
As proposed, we want to ask for feedback about emissary executor.
Emissary executor is currently in Alpha state, but the Kubeflow Pipelines team is actively helping to make it mature. The team has been able to run Kubeflow Pipelines test infra stably with emissary executor. We are now releasing emissary executor as an option when deploying KFP and we are considering making it the default in the future.
Therefore, welcome feedbacks & bug reports for emissary executor!
For feedbacks, comment on this issue.
For bug reports, create a separate issue logging the details and comment about it here.
The text was updated successfully, but these errors were encountered: