Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Posibility to set tolerations for driver pods #11309

Open
jan-stanek opened this issue Oct 18, 2024 · 4 comments
Open

[feature] Posibility to set tolerations for driver pods #11309

jan-stanek opened this issue Oct 18, 2024 · 4 comments

Comments

@jan-stanek
Copy link
Contributor

Feature Area

/area backend

What feature would you like to see?

It would be great to have posibility to set tolerations also for container-driver and dag-driver.

What is the use case or pain point?

We have a cluster where all nodes are tainted, so we are not able to execute any pipeline.

Is there a workaround currently?

It is not possible, we have to use v1 pipelines.


Love this idea? Give it a 👍.

@gregsheremeta
Copy link
Contributor

The interface for controlling driver is typically environment variables. Would you want to set driver tolerations in pipeline code, or would you be ok with an env var on the apiserver deployment that applied to all runs across all pipelines? I ask because from a user api perspective, I don't love leaking things about driver into pipeline code.

@jan-stanek
Copy link
Contributor Author

Env var on the apiserver deployment is enough

@jan-stanek
Copy link
Contributor Author

@gregsheremeta do you know if it can be added in this project or argo workflows has to be changed too?

@gregsheremeta
Copy link
Contributor

There would be no need to make any Argo Workflows modifications. It's probably as simple as modifying this template, but I didn't look too closely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants