Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme pic. #862

Closed
wants to merge 1 commit into from
Closed

Update readme pic. #862

wants to merge 1 commit into from

Conversation

yanggangtony
Copy link
Contributor

What type of PR is this?
/kind bug
/kind cleanup

What this PR does / why we need it:
Update readme pic.

Which issue(s) this PR fixes:
image
image

Update readme pic.
c57a907 
Signed-off-by: yanggang <[email protected]>
@kubean-pr-robot kubean-pr-robot bot added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 4, 2023
@kubean-pr-robot kubean-pr-robot bot requested review from wawa0210 and yankay July 4, 2023 06:48
@kubean-pr-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yanggangtony
To complete the pull request process, please assign wawa0210 after the PR has been reviewed.
You can assign the PR to them by writing /assign @wawa0210 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ErikJiang
Copy link
Member

Please visit: kubean docs to confirm, the current logo image display is normal

@yanggangtony
Copy link
Contributor Author

Please visit: kubean docs to confirm, the current logo image display is normal

You mean the markdown can not be review through the code?

@yanggangtony
Copy link
Contributor Author

The docs is now build by

# Run Chinese documentation locally
$ mkdocs serve -f docs/mkdocs.zh.yml

# Run English documentation locally
$ mkdocs serve -f docs/mkdocs.en.yml

it is just for web review..
custom_dir: './overrides/'.

I will close this pr for mistake.
Thanks.
@ErikJiang

@yanggangtony
Copy link
Contributor Author

/close

@kubean-pr-robot kubean-pr-robot bot closed this Jul 5, 2023
@kubean-pr-robot
Copy link
Contributor

@yanggangtony: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanggangtony yanggangtony deleted the fix-readme-pic branch July 5, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawa0210 wawa0210 Awaiting requested review from wawa0210

@yankay yankay Awaiting requested review from yankay

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanggangtony @ErikJiang