Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore unsupported algorithms #35

Closed
centromere opened this issue Nov 28, 2019 · 4 comments · Fixed by #36
Closed

Ignore unsupported algorithms #35

centromere opened this issue Nov 28, 2019 · 4 comments · Fixed by #36

Comments

@centromere
Copy link

I am using Keycloak as my OIDC provider, and the well-known endpoint advertises PS384 as a supported signing algorithm. Parsing the JSON fails in this case, however this is not ideal. Would it be possible to ignore unsupported algorithms?
@krdlab krdlab mentioned this issue Dec 31, 2019
Merged
@sir4ur0n
Copy link

We just started having the same issue: algorithme PS256 breaks.

  • How about using eitherDecode instead of decode in Web.OIDC.Client.Discovery#discover? At least this would help investigating why the library breaks
  • At least be able to "not break" when algorithms are unknown? E.g. via environment variable

@krdlab
Copy link
Owner

krdlab commented Jan 22, 2020

@centromere @sir4ur0n
Thank you for your report and suggestions!

I think the issue was resolved by #36. I will release a new version.

@krdlab
Copy link
Owner

krdlab commented Jan 25, 2020

0.5.0.0 released. #37

@sir4ur0n
Copy link

Excellent, thank you for your work! We have already upgraded 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unsupported algorithm error krdlab/haskell-oidc-client
3 participants
@centromere @krdlab @sir4ur0n