Add support for serverAPIPath #1197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about:
|
7 tasks
JorTurFer
reviewed
Jul 26, 2023
| @@ -32,6 +33,7 @@ triggers: | |||
| **Parameter list:** | |||
|
|
|||
| - `serverAddress` - Address of Prometheus server. If using VictoriaMetrics cluster version, set full URL to Prometheus querying API, e.g. `http://<vmselect>:8481/select/0/prometheus` | |||
| - `serverAPIPath` - API path to query the Prometheus Server. On Grafana Cloud, this would be `/api/prom`. (Default: `/api/v1/query`) | |||
There was a problem hiding this comment.
Suggested change
| - `serverAPIPath` - API path to query the Prometheus Server. On Grafana Cloud, this would be `/api/prom`. (Default: `/api/v1/query`) | |
| - `serverAPIPath` - API path to query the Prometheus Server. (Default: "/api/v1/query", Optional, ex: On Grafana Cloud, this would be `/api/prom`) |
There was a problem hiding this comment.
I have updated a bit the style to follow the style guide 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new config value for the Prometheus Scaler,
serverAPIPath. This is to support hosted Prometheus vendors who do not expose Prometheus on/api/v1/queryby defaultChecklist