Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Ruby 3.X kwargs #3

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Support Ruby 3.X kwargs #3

merged 1 commit into from
Sep 11, 2024

Conversation

LeipeLeon
Copy link
Member

@LeipeLeon LeipeLeon commented Sep 10, 2024 •
edited
Loading

Add support for **kwargs, e.g. ruby 3.x

@LeipeLeon LeipeLeon changed the base branch from master to bring_up_to_par September 10, 2024 11:16
@LeipeLeon LeipeLeon changed the title Feature/kwargs Support Ruby 3.X kwargs Sep 10, 2024
@LeipeLeon LeipeLeon marked this pull request as ready for review September 10, 2024 11:18
kjwierenga
kjwierenga approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@kjwierenga kjwierenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It works (locally too, tested for Ruby 3.0.7).

Base automatically changed from bring_up_to_par to master September 11, 2024 08:03
@LeipeLeon LeipeLeon merged commit 8025c1f into master Sep 11, 2024
10 checks passed
@LeipeLeon LeipeLeon deleted the feature/kwargs branch September 11, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjwierenga kjwierenga kjwierenga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeipeLeon @kjwierenga