Minor fix to TEST() - allow positive signed 32-bit immediate operands (ruby#209)

Noah Gibbs · web-flow · commit 1a9e29efe588 · 2022-03-03T13:52:46.000-05:00
diff --git a/yjit/src/asm/x86_64/mod.rs b/yjit/src/asm/x86_64/mod.rs
@@ -1327,7 +1327,6 @@ pub fn test(cb: &mut CodeBlock, rm_opnd: X86Opnd, test_opnd: X86Opnd) {
         },
         X86Opnd::Imm(imm) => {
             // This mode only applies to 64-bit R/M operands with 32-bit signed immediates
-            assert!(imm.value < 0);
             assert!(imm.num_bits <= 32);
             assert!(rm_num_bits == 64);
 
diff --git a/yjit/src/asm/x86_64/tests.rs b/yjit/src/asm/x86_64/tests.rs
@@ -381,6 +381,9 @@ fn test_test() {
     check_bytes("4885c0", |cb| test(cb, RAX, RAX));
     check_bytes("4885f0", |cb| test(cb, RAX, RSI));
     check_bytes("48f74640f7ffffff", |cb| test(cb, mem_opnd(64, RSI, 64), imm_opnd(!0x08)));
+    check_bytes("48f7464008000000", |cb| test(cb, mem_opnd(64, RSI, 64), imm_opnd(0x08)));
+    check_bytes("48f7c108000000", |cb| test(cb, RCX, imm_opnd(0x08)));
+    //check_bytes("48a9f7ffff0f", |cb| test(cb, RAX, imm_opnd(0x0FFFFFF7)));
 }
 
 #[test]

Original file line number	Diff line number	Diff line change
`@@ -381,6 +381,9 @@ fn test_test() {`
`381`	`381`	`check_bytes("4885c0", \|cb\| test(cb, RAX, RAX));`
`382`	`382`	`check_bytes("4885f0", \|cb\| test(cb, RAX, RSI));`
`383`	`383`	`check_bytes("48f74640f7ffffff", \|cb\| test(cb, mem_opnd(64, RSI, 64), imm_opnd(!0x08)));`
	`384`	`+ check_bytes("48f7464008000000", \|cb\| test(cb, mem_opnd(64, RSI, 64), imm_opnd(0x08)));`
	`385`	`+ check_bytes("48f7c108000000", \|cb\| test(cb, RCX, imm_opnd(0x08)));`
	`386`	`+ //check_bytes("48a9f7ffff0f", \|cb\| test(cb, RAX, imm_opnd(0x0FFFFFF7)));`
`384`	`387`	`}`
`385`	`388`
`386`	`389`	`#[test]`