Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.captureConsole isn't defaulted correctly if client config is defined #961

Closed
timbertson opened this issue Mar 17, 2014 · 4 comments · Fixed by #1357 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132

Comments

@timbertson
Copy link
Contributor

The new client.captureConsole setting added in #850 (for #744) doesn't get defaulted correctly if you have any client options set. e.g:

client: {
  args: [ /* some args */ ],
},

In this case client.captureConsole is undefined, and you never see any console messages even though it's supposed to be true by default.

This possibly affects all default arguments that are nested.

@adrian-chang
Copy link

+1 Same issue although work around is to set it manually for now... issue I think pops up also in the grunt-runner

Related
karma-runner/grunt-karma#79

@vojtajina vojtajina added this to the v0.14 milestone Mar 29, 2014
@vojtajina
Copy link
Contributor

Oh, thanks @gfxmonk!

@vojtajina
Copy link
Contributor

We should normalize this in config.js, check all the default values (captureConsole, args, useIframe) and if they are not defined, set them to the default value...

Sounds like an easy pull request ;-)

@demisx
Copy link

demisx commented Sep 8, 2014

This issue cost me a few wasted hours. What would be the right place to mention this workaround in the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants