Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose: capture window.confirm #694

Closed
nikitiuk0 opened this issue Aug 11, 2013 · 4 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

Propose: capture window.confirm #694

nikitiuk0 opened this issue Aug 11, 2013 · 4 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Labels
help wanted type: backlog type: feature

Comments

@nikitiuk0
Copy link

As karma already captures window.alert, I think it would be useful to capture window.confirm too.
@vojtajina
Copy link
Contributor

+1 Makes sense.

@vojtajina
Copy link
Contributor

Also window.prompt.

@nikitiuk0
Copy link
Author

Please make sure that you won't break this stuff https://github.com/katranci/Angular-E2E-Window-Dialog-Commands

@vojtajina
Copy link
Contributor

Thanks @DemonShi !

@wesleycho wesleycho mentioned this issue Dec 8, 2016
Merged
@karronoli karronoli mentioned this issue Aug 16, 2022
Merged
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type: backlog type: feature
Projects
None yet
Milestone
No milestone
3 participants
@vojtajina @dignifiedquire @nikitiuk0