-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: Report launcher process error when the process exit event is not emitted #3647
Bug fix: Report launcher process error when the process exit event is not emitted #3647
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
❌ Build karma 2918 failed (commit f5b78c5937 by @) |
❌ Build karma 521 failed (commit f5b78c5937 by @) |
❌ Build karma 520 failed (commit f5b78c5937 by @) |
c7f1c04
to
d42e6cc
Compare
@googlebot I signed it! |
✅ Build karma 522 completed (commit cdc8f51f3c by @) |
✅ Build karma 2919 completed (commit cdc8f51f3c by @) |
✅ Build karma 521 completed (commit cdc8f51f3c by @) |
d42e6cc
to
12491c8
Compare
✅ Build karma 2920 completed (commit a5d35acf91 by @) |
✅ Build karma 523 completed (commit a5d35acf91 by @) |
✅ Build karma 522 completed (commit a5d35acf91 by @) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, one fix up please.
12491c8
to
f896323
Compare
✅ Build karma 2921 completed (commit c4bdbd38a5 by @) |
✅ Build karma 524 completed (commit c4bdbd38a5 by @) |
✅ Build karma 523 completed (commit c4bdbd38a5 by @) |
@johnjbarton I see the build on master is failing commit message validation due to the fact the pull request ID was appended to the commit message on merge. Original Commit Message - 65 chars: What can we do about this? |
@johnjbarton Potential fix => #3650 |
🎉 This PR is included in version 6.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…rma-runner#3647) Co-authored-by: Chris Bottin <[email protected]>
## [6.1.1](karma-runner/karma@v6.1.0...v6.1.1) (2021-02-12) ### Bug Fixes * **config:** check extension before ts-node register ([karma-runner#3651](karma-runner#3651)) ([474f4e1](karma-runner@474f4e1)), closes [karma-runner#3329](karma-runner#3329) * report launcher process error when exit event is not emitted ([karma-runner#3647](karma-runner#3647)) ([7ab86be](karma-runner@7ab86be))
This PR is to ensure the launcher process error is reported in the logs when the process exit event is not emitted which can happen in some cases.
As per described on this page https://nodejs.org/api/child_process.html#child_process_event_error, "The 'exit' event may or may not fire after an error has occurred. When listening to both the 'exit' and 'error' events, guard against accidentally invoking handler functions multiple times."
Without this fix, if the browser binary file is missing, Karma will report the following if only in Debug mode:
This is not really helpful to the users and if debug log level is not set, they won't see this message.
With this fix, if the browser binary file is missing, Karma will always report the following:
This error is clear to the users and always visible