Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): set maxHttpBufferSize to the socket.io v2 default #3626

Merged
merged 1 commit into from
Jan 20, 2021
Merged

fix(server): set maxHttpBufferSize to the socket.io v2 default #3626

merged 1 commit into from
Jan 20, 2021

Conversation

johnjbarton
Copy link
Contributor

Fixes #3621

@karmarunnerbot
Copy link
Member

✅ Build karma 471 completed (commit c4899f0459 by @johnjbarton)

@AppVeyorBot
Copy link

✅ Build karma 2868 completed (commit c4899f0459 by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 470 completed (commit c4899f0459 by @johnjbarton)

devoto13
devoto13 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@ddolcimascolo
Copy link

Thx @johnjbarton

@johnjbarton johnjbarton merged commit 69baddc into karma-runner:master Jan 20, 2021
@robertknight robertknight mentioned this pull request Jan 20, 2021
Closed
karmarunnerbot pushed a commit that referenced this pull request Jan 20, 2021
@semantic-release-bot
chore(release): 6.0.1 [skip ci]
e246461 
## [6.0.1](v6.0.0...v6.0.1) (2021-01-20)

### Bug Fixes

* **server:** set maxHttpBufferSize to the socket.io v2 default ([#3626](#3626)) ([69baddc](69baddc)), closes [#3621](#3621)
* restore `customFileHandlers` provider ([#3624](#3624)) ([25d9abb](25d9abb))
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@johnjbarton @anthony-redFox
fix(server): set maxHttpBufferSize to the socket.io v2 default (karma…
92953b2 
…-runner#3626)

Fixes karma-runner#3621
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@semantic-release-bot @anthony-redFox
chore(release): 6.0.1 [skip ci]
72aeca4 
## [6.0.1](karma-runner/karma@v6.0.0...v6.0.1) (2021-01-20)

### Bug Fixes

* **server:** set maxHttpBufferSize to the socket.io v2 default ([karma-runner#3626](karma-runner#3626)) ([69baddc](karma-runner@69baddc)), closes [karma-runner#3621](karma-runner#3621)
* restore `customFileHandlers` provider ([karma-runner#3624](karma-runner#3624)) ([25d9abb](karma-runner@25d9abb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoto13 devoto13 devoto13 approved these changes

@jginsburgn jginsburgn Awaiting requested review from jginsburgn

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v6 coverage runs can fail dues to maxHttpBufferSize change in socket.io v3
5 participants
@johnjbarton @karmarunnerbot @AppVeyorBot @ddolcimascolo @devoto13