fix(server): echo the hostname rather than listenAddress #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build karma 312 completed (commit cd9a5230ca by @johnjbarton) |
|
✅ Build karma 311 completed (commit cd9a5230ca by @johnjbarton) |
kyliau
reviewed
Jun 12, 2020
kyliau
approved these changes
Jun 12, 2020
|
✅ Build karma 2710 completed (commit cd9a5230ca by @johnjbarton) |
The listenAddress is an IP level number, which may be "::" on IPV6. The hostname is a string set in a /etc config file. When these differ the hostname is clearer.
|
❌ Build karma 320 failed (commit 1f2dd6c3ef by @johnjbarton) |
|
❌ Build karma 2718 failed (commit eb29237236 by @johnjbarton) |
|
✅ Build karma 319 completed (commit eb29237236 by @johnjbarton) |
karmarunnerbot
pushed a commit
that referenced
this pull request
Jul 28, 2020
## [5.1.1](v5.1.0...v5.1.1) (2020-07-28) ### Bug Fixes * **server:** echo the hostname rather than listenAddress ([#3532](#3532)) ([ebe7ce4](ebe7ce4))
|
🎉 This PR is included in version 5.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
…r#3532) The listenAddress is an IP level number, which may be "::" on IPV6. The hostname is a string set in a /etc config file. When these differ the hostname is clearer.
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
## [5.1.1](karma-runner/karma@v5.1.0...v5.1.1) (2020-07-28) ### Bug Fixes * **server:** echo the hostname rather than listenAddress ([karma-runner#3532](karma-runner#3532)) ([ebe7ce4](karma-runner@ebe7ce4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When these differ the hostname is clearer.