fix(proxy): use keepAlive agent #3527
Conversation
|
✅ Build karma 2701 completed (commit 6fa29d34f5 by @matz3) |
|
✅ Build karma 302 completed (commit 6fa29d34f5 by @matz3) |
|
✅ Build karma 303 completed (commit 6fa29d34f5 by @matz3) |
|
✅ Build karma 304 completed (commit e2978de21f by @matz3) |
|
✅ Build karma 2702 completed (commit d60c75b060 by @matz3) |
|
✅ Build karma 303 completed (commit d60c75b060 by @matz3) |
|
✅ Build karma 2703 completed (commit cdae43add2 by @matz3) |
|
✅ Build karma 304 completed (commit 94fb88eaf0 by @matz3) |
|
✅ Build karma 305 completed (commit cdae43add2 by @matz3) |
There was a problem hiding this comment.
Overall LGTM
We already have a E2E test for HTTP proxy here. Ideally we would want to test that proxy connections are re-used, but it may be tricky to implement such test. It should be enough to test that feature itself works correctly + a unit test to verify that correct agent is used.
nit: Consider squashing commits and changing commit to "feat(proxy): ..." as this was not broken before, this is a new feature.
Using an agent with keepAlive improves performance as the socket is reused across multiple requests.
matz3
force-pushed
the
proxy-keepAlive-agent
branch
from
f25edeb
to
7e4df8a
Compare
|
Thanks for your review! I've squashed the commits and adopted the message. |
|
✅ Build karma 2709 completed (commit ac23b439bb by @matz3) |
|
✅ Build karma 311 completed (commit ac23b439bb by @matz3) |
|
✅ Build karma 310 completed (commit ac23b439bb by @matz3) |
# [5.1.0](v5.0.9...v5.1.0) (2020-06-11) ### Features * **proxy:** use keepAlive agent ([#3527](#3527)) ([b77f94c](b77f94c))
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Using an agent with keepAlive improves performance as the socket is reused across multiple requests.
# [5.1.0](karma-runner/karma@v5.0.9...v5.1.0) (2020-06-11) ### Features * **proxy:** use keepAlive agent ([karma-runner#3527](karma-runner#3527)) ([b77f94c](karma-runner@b77f94c))
Using an agent with keepAlive improves performance as the socket is
reused across multiple requests.