feat(config): add failOnSkippedTests option. #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjbarton
force-pushed
the
fail-on-pending
branch
from
1a20132
to
581bfd7
Compare
kyliau
requested changes
Oct 15, 2019
Recently jasmine added support for reporting pending (incl due to fit()) tests. This appears in results as skipped tests and this option allows us to fail tests with skipped tests' '
johnjbarton
force-pushed
the
fail-on-pending
branch
from
581bfd7
to
44958d1
Compare
|
✅ Build karma 2414 completed (commit 89a68f110e by @johnjbarton) |
|
✅ Build karma 16 completed (commit 89a68f110e by @johnjbarton) |
|
✅ Build karma 15 completed (commit 89a68f110e by @johnjbarton) |
johnjbarton
changed the title
|
✅ Build karma 2417 completed (commit 6180b2e4a4 by @johnjbarton) |
|
✅ Build karma 19 completed (commit 6180b2e4a4 by @johnjbarton) |
|
✅ Build karma 18 completed (commit 6180b2e4a4 by @johnjbarton) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently jasmine added support for reporting pending (incl due to fit()) tests.
These appear in results as skipped tests and this failOnPendingTests option allows us to fail tests
with skipped tests.