Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): fix issue with loaded on safari 10 #3252

Merged

Conversation

curquhart
Copy link
Contributor

@curquhart curquhart commented Jan 16, 2019

fix(client): fix issue with loaded on safari 10

Safari 10 supports type=module but ignores nomodule which causes loaded() to execute twice.

Fixes #3198

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@curquhart curquhart force-pushed the fix_double_loaded_safari_10 branch from ff9fdd5 to 5f41b08 Compare January 16, 2019 19:02
Safari 10 supports type=module but ignores nomodule which causes loaded() to execute twice.

Fixes karma-runner#3198
@curquhart curquhart force-pushed the fix_double_loaded_safari_10 branch from 5f41b08 to e4e8d82 Compare January 16, 2019 20:20
@googlebot
Copy link

CLAs look good, thanks!

@johnjbarton johnjbarton merged commit 571191c into karma-runner:master Jan 18, 2019
@curquhart curquhart deleted the fix_double_loaded_safari_10 branch February 6, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mac OSX only] You need to include some adapter that implements __karma__.start method!
3 participants