-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove logged output #3215
Remove logged output #3215
Conversation
This line throws `TypeError: Converting circular structure to JSON` and there's no way to disable it, even though the config that's used it perfectly valid.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuration errors are common and the config can be changed dynamically by plugins. Logging the final config is a critical step in debugging user issues.
You could:
- Find a way to log the config without json.stringify.
- Wrap the stringify line with try/catch and log a debug message that the attempt to log the config failed.
Either way, wrapping the code in a check on the logLevel === debug would be great.
Or we can switch to flatted: https://www.npmjs.com/package/flatted |
Remove json3 dep and use, probably was needed for older node code. Fixes karma-runner#3215
Remove json3 dep and use, probably was needed for older node code. Fixes karma-runner#3215
Remove json3 dep and use, probably was needed for older node code. Fixes karma-runner#3215
Remove json3 dep and use, probably was needed for older node code. Fixes #3215
This line throws
TypeError: Converting circular structure to JSON
and there's no way to disable it, even though the config that's used it perfectly valid.Check that your description matches the automatic change-log format:
http://karma-runner.github.io/latest/dev/git-commit-msg.html
then delete this reminder.