Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logged output #3215

Closed
wants to merge 1 commit into from
Closed

Remove logged output #3215

wants to merge 1 commit into from

Conversation

swimmadude66
Copy link

This line throws TypeError: Converting circular structure to JSON and there's no way to disable it, even though the config that's used it perfectly valid.

Check that your description matches the automatic change-log format:
http://karma-runner.github.io/latest/dev/git-commit-msg.html
then delete this reminder.

This line throws `TypeError: Converting circular structure to JSON` and there's no way to disable it, even though the config that's used it perfectly valid.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration errors are common and the config can be changed dynamically by plugins. Logging the final config is a critical step in debugging user issues.

You could:

  1. Find a way to log the config without json.stringify.
  2. Wrap the stringify line with try/catch and log a debug message that the attempt to log the config failed.

Either way, wrapping the code in a check on the logLevel === debug would be great.

@johnjbarton
Copy link
Contributor

Or we can switch to flatted: https://www.npmjs.com/package/flatted
That would seem to be the best, we can replace json3:
https://github.com/karma-runner/karma/search?q=json3&unscoped_q=json3
and solve your issue as well.

johnjbarton added a commit to johnjbarton/karma that referenced this pull request Nov 26, 2018
Remove json3 dep and use, probably was needed for older node code.
Fixes karma-runner#3215
johnjbarton added a commit to johnjbarton/karma that referenced this pull request Nov 27, 2018
Remove json3 dep and use, probably was needed for older node code.
Fixes karma-runner#3215
johnjbarton added a commit to johnjbarton/karma that referenced this pull request Nov 27, 2018
Remove json3 dep and use, probably was needed for older node code.
Fixes karma-runner#3215
johnjbarton added a commit that referenced this pull request Nov 28, 2018
Remove json3 dep and use, probably was needed for older node code.
Fixes #3215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants