Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Wait 30s for browser activity per Travis. #3091

Merged

Conversation

@johnjbarton
Copy link
Contributor Author

Sorry, I only discovered this when trying to further debug the fails.

@johnjbarton johnjbarton requested a review from zzo July 27, 2018 21:30
@johnjbarton johnjbarton force-pushed the phantomjs-disconnect-30 branch from c6f76c0 to 8c458e7 Compare July 27, 2018 21:38
Copy link
Contributor

@zzo zzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting but the 'error' in the logs complains that there's a timeout after 10 seconds so not sure chaning this is going to make a difference?
Do you think people are setting it to 10 seconds and that's the problem?

@johnjbarton
Copy link
Contributor Author

Yes, 10s was the previous default. 30s is too high for local testing, but CI machines are much slower.

@@ -343,7 +343,7 @@ class Config {
}
this.browserDisconnectTimeout = 2000
this.browserDisconnectTolerance = 0
this.browserNoActivityTimeout = 20000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous default was 20s?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, in #3087 two days ago I set it to 20s. Then I saw the travis page recommending 30s. bah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants