Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<any_browser_here> process gets killed forcibly after 2000 ms #2447

Closed
charpour opened this issue Nov 10, 2016 · 3 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122, Omrisnyk/npm-lockfiles#132 or satoshinakamoto007/bitcore#1135
Closed

<any_browser_here> process gets killed forcibly after 2000 ms #2447

charpour opened this issue Nov 10, 2016 · 3 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122, Omrisnyk/npm-lockfiles#132 or satoshinakamoto007/bitcore#1135
Labels
help wanted

Comments

@charpour
Copy link

Expected behaviour

The behaviour as to when to kill the browser should be configurable. There is a hardcoded value in karma/lib/launchers/process.js which is var killTimeout = 2000

Actual behaviour

Since the value is not configurable the browser gets killed after 2s. If there's something running within the browser (e.g. when using karma-coverage and istanbul works on a large number of files), it gets killed.

Environment Details

  • Karma version (output of karma --version): 1.3.0
  • Relevant part of your karma.config.js file: not available

Steps to reproduce the behaviour

  1. Configure karma-coverage to run on a big code base
  2. Run karma
  3. Observe how the browser gets killed after 2s before it has a chance to finish processing the coverage data
@vivganes vivganes mentioned this issue Nov 25, 2016
Closed
@vivganes
Copy link
Contributor

@maksimr Is it okay if I try to submit a pull request for this issue?

(Thinking aloud) --> I need to setup a provision for a new property in karma config to read the SIGKILL timeout. Let the default value be the current default value but when the user sets this value to some number in milliseconds, we need to honor that by waiting that many milliseconds before a forced SIGKILL.

Will this work?

@maksimr
Copy link
Contributor

maksimr commented Nov 27, 2016

@vivganes sure

I need to setup a provision for a new ... many milliseconds before a forced SIGKILL.

sounds good!

Thanks!

@charpour
Copy link
Author

@vivganes thanks for taking a peek at it.

This was referenced Jan 12, 2017
Merged
Closed
@vivganes vivganes mentioned this issue Jan 19, 2017
Merged
@karronoli karronoli mentioned this issue Aug 16, 2022
Merged
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this issue Sep 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
3 participants
@maksimr @vivganes @charpour