Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Export all the constants #2361

Closed
ghost opened this issue Sep 16, 2016 · 2 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

Feature Request: Export all the constants #2361

ghost opened this issue Sep 16, 2016 · 2 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Labels
help wanted type: feature

Comments

@ghost
Copy link

ghost commented Sep 16, 2016 •
edited by ghost
Loading

Expected behaviour

All the constants would be exported.

Actual behaviour

Only the VERSION constant is exported in the index.html

Environment Details

  • Karma version 1.3.0

Reasoning

We use gulp and we want to specify the log level via the Server constructor but it would be more reliable to use the constants defined inside karma than magic string like 'DEBUG'
@ghost
Copy link
Author

ghost commented Sep 16, 2016

This should be a trivial change. I'm more than willing to do a pull request

@dignifiedquire
Copy link
Member

Sure :) PR welcome.

@wesleycho wesleycho mentioned this issue Dec 4, 2016
Merged
@karronoli karronoli mentioned this issue Aug 16, 2022
Merged
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type: feature
Projects
None yet
Milestone
No milestone
1 participant
@dignifiedquire