Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use lodash find() instead of Array.prototype.find #1533

Merged

Conversation

kketch
Copy link

@kketch kketch commented Aug 3, 2015

When i upgraded to from Karma 0.12.x to 0.13.3, my karma setup stopped working.

file-list.js uses ES6 Array.prototype.find which of course fails with TypeError: undefined is not a function in normal node installations (without the harmony flag).

Replacing Array.prototype.find() with lodash.find() (which is already used in other places in file-list.js) seems to fix the issue.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dignifiedquire
Copy link
Member

Thanks, could you change the commit message to follow our convention please?

Use lodash find() instead of ES6 Array.prototype.find.
ES6 find is not available on standard node installations
(without the harmony flag)

Closes karma-runner#1533
@kketch kketch force-pushed the fix-es6-array-find-usage branch from 0290295 to 3bd15a7 Compare August 4, 2015 09:30
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@kketch
Copy link
Author

kketch commented Aug 4, 2015

fixed the commit message

@dignifiedquire
Copy link
Member

Thanks :octocat:

dignifiedquire added a commit that referenced this pull request Aug 4, 2015
use lodash find() instead of Array.prototype.find
@dignifiedquire dignifiedquire merged commit f8a41e4 into karma-runner:master Aug 4, 2015
@dignifiedquire
Copy link
Member

Released in v0.13.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants