Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jasmine] Rerun all tests when the failing tests pass #148

Closed
francoisfrisch opened this issue Oct 30, 2012 · 5 comments · Fixed by #361
Closed

[Jasmine] Rerun all tests when the failing tests pass #148

francoisfrisch opened this issue Oct 30, 2012 · 5 comments · Fixed by #361

Comments

@francoisfrisch
Copy link

While Testacular is in the mode were it is only running the last failed specs, when all those tests pass I think Testacular should kick off another run to go through all the tests again just to make sure none of the tests which might overlap still pass.

@vojtajina
Copy link
Contributor

Totally. I already have this on my list. +1

@BorisKozo
Copy link

+1 to that. Just had that issue where it said SUCCESS when in reality it ran only 1 test and 3 other tests were broken.

@vojtajina
Copy link
Contributor

Guys, what do you think, if we just remove this anti-feature ?

  • it's not implemented in other adapters and nobody really missed it
  • it's flaky as it uses jasmine's ids to determine which specs to run (and these ids are assigned based on the order of specs, so the same spec can in some cases get a different id next run)

I would just remove the magic and say, if you only want to execute specific test, use iit or ddescribe.

@BorisKozo
Copy link

Sounds good to me.

On Thursday, February 21, 2013, Vojta Jina wrote:

Guys, what do you think, if we just remove this anti-feature ?

  • it's not implemented in other adapters and nobody really missed it
  • it's flaky as it uses jasmine's ids to determine which specs to run
    (and these ids are assigned based on the order of specs, so the same spec
    can in some cases get a different id next run)

I would just remove the magic and say, if you only want to execute
specific test, use iit or ddescribe.


Reply to this email directly or view it on GitHubhttps://github.com/testacular/testacular/issues/148#issuecomment-13870617.

@francoisfrisch
Copy link
Author

I agree, it seems like a great feature but it gets in the way often, and it's not easy to reset on demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants