Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command line I/F #1351

Closed
koba04 opened this issue Mar 16, 2015 · 5 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

command line I/F #1351

koba04 opened this issue Mar 16, 2015 · 5 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132

Comments

@koba04
Copy link

koba04 commented Mar 16, 2015

Currently, karma doesn't export karma command.
You recommend to install karma-cli locally to the project in case of npm test.
This is why It's for separation of concerns. #1078 #1322

But, some documents describe using ./node_modules/karma/bin/karma now.

https://github.com/karma-runner/karma/blob/master/docs/plus/02-travis.md
https://github.com/karma-runner/karma/blob/master/docs/plus/04-semaphore.md

In addition, karma-cli specifies the preferGlobal.
https://github.com/karma-runner/karma-cli/blob/master/package.json#L41

I feel that there is no consistency.

Solution

  1. Export karma command and treats karma-cli as just global command I/F. (+1)
  2. Remove bin/karma from this repository and remove the preferGlobal from karma-cli.

Thank you.

@maksimr
Copy link
Contributor

maksimr commented Mar 16, 2015

/cc @karma-runner/contributors

@peter-mouland
Copy link

but running ./node_modules/karma/bin/karma start xx.js does work. so having the bin/karma makes sense.

I would prefer to keep bin/karma and add this to the bin object within karma's package.json. This would mean that in my package.json scripts.test i could write write karma start xx.js.

@koba04
Copy link
Author

koba04 commented Mar 24, 2015

I agree with @peter-mouland.
I hope bin/karma is specified in package.json's bin field.

@dignifiedquire
Copy link
Member

This will be fixed with #1078

@koba04
Copy link
Author

koba04 commented May 23, 2015

@dignifiedquire Great! I'm looking forward to fixing this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants