feat(runner): Use favicon in static runner pages

I noticed a "TOOD" [sic] in the runner page source that was added by e9fa51a. I figured I'd take a swing at doing it. This commit brings down the favicon from http://karma-runner.github.io/assets/img/favicon/favicon.ico and wires up the static pages to use it. I considered inlining it as a data-uri, but the image was big enough to make the source pretty gross so I settled on using an external file. Along the way, I found and fixed a couple of minor spelling and whitespace errors.
karma-runner · May 20, 2015 · 6cded4f · 6cded4f
1 parent 1b69db1
commit 6cded4f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/static/client.html b/static/client.html
@@ -7,8 +7,7 @@
 <head>
 %X_UA_COMPATIBLE%
   <title>Karma</title>
-  <!-- TOOD(vojta): create simple favicon and cache it -->
-  <link href="data:image/x-icon;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQEAYAAABPYyMiAAAABmJLR0T///////8JWPfcAAAACXBIWXMAAABIAAAASABGyWs+AAAAF0lEQVRIx2NgGAWjYBSMglEwCkbBSAcACBAAAeaR9cIAAAAASUVORK5CYII=" rel="icon" type="image/x-icon">
+  <link href="favicon.ico" rel="icon" type="image/x-icon">
   <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
   <style type="text/css">
     iframe {
@@ -31,7 +30,6 @@
 
     .online {
       background: #6C4;
-
     }
 
     .idle {

diff --git a/static/context.html b/static/context.html
@@ -2,7 +2,7 @@
 <!--
 This is the execution context.
 Loaded within the iframe.
-Realoaded before every execution run.
+Reloaded before every execution run.
 -->
 <html>
 <head>

diff --git a/static/debug.html b/static/debug.html
@@ -1,15 +1,14 @@
 <!doctype html>
 <!--
 This file is almost the same as context.html - loads all source files,
-but it's purpose is to be loaded in the main frame (not within an iframe),
+but its purpose is to be loaded in the main frame (not within an iframe),
 just for immediate execution, without reporting to Karma server.
 -->
 <html>
 <head>
 %X_UA_COMPATIBLE%
   <title>Karma DEBUG RUNNER</title>
-  <!-- TOOD(vojta): create simple favicon and cache it -->
-  <link href="data:image/x-icon;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQEAYAAABPYyMiAAAABmJLR0T///////8JWPfcAAAACXBIWXMAAABIAAAASABGyWs+AAAAF0lEQVRIx2NgGAWjYBSMglEwCkbBSAcACBAAAeaR9cIAAAAASUVORK5CYII=" rel="icon" type="image/x-icon" />
+  <link href="favicon.ico" rel="icon" type="image/x-icon" />
   <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
 </head>
 <body>

diff --git a/static/favicon.ico b/static/favicon.ico