fix(agents-api): Fix cozo query retry logic #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julep Developers <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1cb5932 in 11 seconds
More details
- Looked at
88lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/gunicorn_conf.py:7
- Draft comment:
Reducing workers from(multiprocessing.cpu_count() - 1)to(multiprocessing.cpu_count() // 2)may impact performance on systems with fewer cores. Ensure this change aligns with expected load and performance requirements. - Reason this comment was not posted:
Confidence changes required:50%
The change in the number of workers from (cpu_count() - 1) to (cpu_count() // 2) might affect performance, especially on systems with fewer cores. This change should be justified based on the expected load and performance characteristics.
Workflow ID: wflow_DgUHgFMb5aYrmAAk
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
![standard-input[bot]](https://avatars.githubusercontent.com/in/1011034?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Improves Cozo query retry logic and adjusts Gunicorn worker configuration.
utils.py, updated retry logic incozo_queryandcozo_query_asyncto handleConnectionError,Timeout,TimeoutException,NetworkError, andRequestError.gunicorn_conf.pyto use half of CPU count instead of CPU count minus one.This description was created by
for 1cb5932. It will automatically update as commits are pushed.