Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: juampi92/phecks
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.2
Choose a base ref
...
head repository: juampi92/phecks
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.2
Choose a head ref
  • 16 commits
  • 47 files changed
  • 2 contributors

Commits on Jul 26, 2022

  1. better config comments

    juampi92 committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    4f78361 View commit details
    Browse the repository at this point in the history
  2. added to-do on readme

    juampi92 committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    3d511f3 View commit details
    Browse the repository at this point in the history
  3. fix broken test

    juampi92 committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    e9afea8 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Update package name

    We need a new name to import it with no conflicts
    juampi92 authored Jul 28, 2022
    Configuration menu
    Copy the full SHA
    7858c9c View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Configuration menu
    Copy the full SHA
    ab5a5e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Move to DataProvider

    juampi92 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    a7b75ec View commit details
    Browse the repository at this point in the history
  2. ViolationBuilder test

    juampi92 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    220450c View commit details
    Browse the repository at this point in the history
  3. Update ViolationBuilder signature + Update Check interface breaking c…

    …hanges
    
    == Check Interface ==
    Instead of having one `run()` method, now we separated the getMatches with processMatch methods.
    
    In a way, it's similar to PHPStan's Rule interface. getNodeTypes and processNodes.
    
    The processMatch method returns an array of ViolationBuilder instances. If it returns an empty array, the match will not be counted as a violation.
    
    The ViolationBuilder now changed. The identifier and file are not required. If they are not present, they will be added automatically by the CheckRunner. If they are present, they won't be changed.
    
    == ViolationBuilder ==
    
    The explanation is changed for `message` now. And the `build` method should not be called from the processMatch. It will be called from the CheckRunner, with the fallback identifier as the check name, and the fallback file as the match found initially.
    juampi92 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    f44609b View commit details
    Browse the repository at this point in the history
  4. Readme and changelog

    juampi92 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    eaed49c View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Merge pull request #1 from StuDocu/feature/reflection-extractors

    Feature/Reflection extractors
    juampi92 authored Aug 8, 2022
    Configuration menu
    Copy the full SHA
    d018835 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    516a42d View commit details
    Browse the repository at this point in the history
  3. phpstan

    juampi92 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    8fd2eef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4bd8bde View commit details
    Browse the repository at this point in the history
  5. phpstan + php-cs-fix

    juampi92 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    a5e57d3 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1 from juampi92/1.x

    1.x
    juampi92 authored Aug 8, 2022
    Configuration menu
    Copy the full SHA
    5fb8cd5 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #2 from StuDocu/develop

    Develop
    juampi92 authored Aug 8, 2022
    Configuration menu
    Copy the full SHA
    3da508c View commit details
    Browse the repository at this point in the history
Loading