Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:matches() CSS pseudo-class does not match any elements in querySelectorAll() #3013

Closed
danburzo opened this issue Jul 21, 2020 · 2 comments
Closed

:matches() CSS pseudo-class does not match any elements in querySelectorAll() #3013

danburzo opened this issue Jul 21, 2020 · 2 comments
Labels
selectors CSS Selectors support

Comments

@danburzo
Copy link

danburzo commented Jul 21, 2020 •
edited
Loading

Basic info:

  • Node.js version: v14.2.0 (local), v10.21.0 (Runkit)
  • jsdom version: 16.3.0

Minimal reproduction case

let { JSDOM } = require('jsdom');
let doc = new JSDOM(`
    <h2>Heading</h2>
    <h3>Subheading</h3>
`).window.document;

console.log([...doc.querySelectorAll('h2,h3')]); // => 2 elements
console.log([...doc.querySelectorAll(':matches(h2,h3)')]); // => 0 elements

Runkit live demo

How does similar code behave in browsers?

In Firefox 78, which supports the :is() selector, both queries result in two elements. Safari, for :matches(), and Chrome, for :-webkit-any(), give the same result.

I know things are still in flux in regards to the :is() and :where() pseudo-classes, but since the :matches() selector exists in JSDOM it is suprising behavior.
@danburzo danburzo changed the title :matches CSS selector does not match any elements :matches() CSS pseudo-class does not match any elements in querySelectorAll() Jul 21, 2020
@domenic domenic added the selectors CSS Selectors support label Aug 8, 2020
@domenic
Copy link
Member

domenic commented Aug 8, 2020

I'm not sure what to do with this issue. Why do you think JSDOM supports :matches()? The intention is to only support standards, and :matches() is non-standard.

It'd be worth filing a feature request for :is() on https://github.com/dperini/nwsapi, perhaps.

@danburzo danburzo mentioned this issue Aug 9, 2020
Closed
@danburzo
Copy link
Author

danburzo commented Aug 9, 2020

I initially expected it to work because it seemed to support a single selector (e.g. :matches(h2)) and it didn't complain matches was an unrecognized pseudo-class. I wasn't aware of the separate nwsapi project, that sounds like the right place to file an issue / feature request.

I guess we can close this issue, right? I can submit a PR once/if the feature makes it in nwsapi.

@domenic domenic closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
selectors CSS Selectors support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danburzo @domenic