Dimensions: allow modification of coordinates argument

markelog · markelog · commit f7e60dc83d81 · 2014-11-16T18:05:29.000+03:00
Fixes gh-1848 Closes gh-1853
diff --git a/src/offset.js b/src/offset.js
@@ -51,7 +51,9 @@ jQuery.offset = {
 		}
 
 		if ( jQuery.isFunction( options ) ) {
-			options = options.call( elem, i, curOffset );
+
+			// Use jQuery.extend here to allow modification of coordinates argument (gh-1848)
+			options = options.call( elem, i, jQuery.extend( {}, curOffset ) );
 		}
 
 		if ( options.top != null ) {
diff --git a/test/unit/dimensions.js b/test/unit/dimensions.js
@@ -455,4 +455,16 @@ testIframe( "dimensions/documentLarge", "window vs. large document", function( j
 	ok( jQuery( document ).width() > jQuery( window ).width(), "document width is larger than window width" );
 });
 
+test( "allow modification of coordinates argument (gh-1848)", 1, function() {
+	var element = jQuery( "<div/>" ).appendTo( "#qunit-fixture" );
+
+	element.offset(function( index, coords ) {
+		coords.top = 100;
+
+		return coords;
+	});
+
+	equal( element.offset().top, 100, "coordinates are modified" );
+});
+
 })();

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,9 @@ jQuery.offset = {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`if ( jQuery.isFunction( options ) ) {`
`54`		`- options = options.call( elem, i, curOffset );`
	`54`	`+`
	`55`	`+ // Use jQuery.extend here to allow modification of coordinates argument (gh-1848)`
	`56`	`+ options = options.call( elem, i, jQuery.extend( {}, curOffset ) );`
`55`	`57`	`}`
`56`	`58`
`57`	`59`	`if ( options.top != null ) {`