Skip to content

Commit d3d8d97

Browse files
committed
Tests: Provide equal() arguments in correct order (actual, expected)
Ref 2242719 Ref f5bf9bc
1 parent 0e98243 commit d3d8d97

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

test/unit/data.js

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -824,25 +824,25 @@ QUnit.test( "acceptData", function( assert ) {
824824

825825
var flash, pdf, form;
826826

827-
assert.equal( 42, jQuery( document ).data( "test", 42 ).data( "test" ), "document" );
828-
assert.equal( 42, jQuery( document.documentElement ).data( "test", 42 ).data( "test" ), "documentElement" );
829-
assert.equal( 42, jQuery( {} ).data( "test", 42 ).data( "test" ), "object" );
830-
assert.equal( 42, jQuery( document.createElement( "embed" ) ).data( "test", 42 ).data( "test" ), "embed" );
827+
assert.equal( jQuery( document ).data( "test", 42 ).data( "test" ), 42, "document" );
828+
assert.equal( jQuery( document.documentElement ).data( "test", 42 ).data( "test" ), 42, "documentElement" );
829+
assert.equal( jQuery( {} ).data( "test", 42 ).data( "test" ), 42, "object" );
830+
assert.equal( jQuery( document.createElement( "embed" ) ).data( "test", 42 ).data( "test" ), 42, "embed" );
831831

832832
flash = document.createElement( "object" );
833833
flash.setAttribute( "classid", "clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" );
834-
assert.equal( 42, jQuery( flash ).data( "test", 42 ).data( "test" ), "flash" );
834+
assert.equal( jQuery( flash ).data( "test", 42 ).data( "test" ), 42, "flash" );
835835

836836
pdf = document.createElement( "object" );
837837
pdf.setAttribute( "classid", "clsid:CA8A9780-280D-11CF-A24D-444553540000" );
838-
assert.equal( 42, jQuery( pdf ).data( "test", 42 ).data( "test" ), "pdf" );
838+
assert.equal( jQuery( pdf ).data( "test", 42 ).data( "test" ), 42, "pdf" );
839839

840-
assert.equal( undefined, jQuery( document.createComment( "" ) ).data( "test", 42 ).data( "test" ), "comment" );
841-
assert.equal( undefined, jQuery( document.createTextNode( "" ) ).data( "test", 42 ).data( "test" ), "text" );
842-
assert.equal( undefined, jQuery( document.createDocumentFragment() ).data( "test", 42 ).data( "test" ), "documentFragment" );
840+
assert.strictEqual( jQuery( document.createComment( "" ) ).data( "test", 42 ).data( "test" ), undefined, "comment" );
841+
assert.strictEqual( jQuery( document.createTextNode( "" ) ).data( "test", 42 ).data( "test" ), undefined, "text" );
842+
assert.strictEqual( jQuery( document.createDocumentFragment() ).data( "test", 42 ).data( "test" ), undefined, "documentFragment" );
843843

844844
form = jQuery( "#form" ).append( "<input id='nodeType'/><input id='nodeName'/>" )[ 0 ];
845-
assert.equal( 42, jQuery( form ) .data( "test", 42 ).data( "test" ), "form with aliased DOM properties" );
845+
assert.equal( jQuery( form ) .data( "test", 42 ).data( "test" ), 42, "form with aliased DOM properties" );
846846
} );
847847

848848
QUnit.test( "Check proper data removal of non-element descendants nodes (#8335)", function( assert ) {
@@ -906,8 +906,9 @@ QUnit.test( ".data(prop) does not create expando", function( assert ) {
906906
var key,
907907
div = jQuery( "<div/>" );
908908

909-
div.data("foo");
910-
assert.equal( false, jQuery.hasData( div[0] ) );
909+
div.data( "foo" );
910+
assert.equal( jQuery.hasData( div[ 0 ] ), false, "No data exists after access" );
911+
911912
// Make sure no expando has been added
912913
for ( key in div[ 0 ] ) {
913914
if ( /^jQuery/.test( key ) ) {

0 commit comments

Comments
 (0)