Event: Normalize mouse event properties in drag events

araghava · dmethvin · commit 97cf52808240 · 2015-01-05T15:34:52.000-05:00
DragEvent is a superset of MouseEvent, so we want to fix up mouse properties like pageX and pageY. Fixes gh-1925
diff --git a/src/event.js b/src/event.js
@@ -14,7 +14,7 @@ define([
 
 var
 	rkeyEvent = /^key/,
-	rmouseEvent = /^(?:mouse|pointer|contextmenu)|click/,
+	rmouseEvent = /^(?:mouse|pointer|contextmenu|drag)|click/,
 	rfocusMorph = /^(?:focusinfocus|focusoutblur)$/,
 	rtypenamespace = /^([^.]*)(?:\.(.+)|)/;
 
diff --git a/test/unit/event.js b/test/unit/event.js
@@ -2444,6 +2444,20 @@ test("fixHooks extensions", function() {
 	jQuery.event.fixHooks.click = saved;
 });
 
+test( "drag events copy over mouse related event properties (gh-1925)", function() {
+	expect( 2 );
+
+	var $fixture = jQuery( "<div id='drag-fixture'></div>" ).appendTo( "body" );
+
+	$fixture.on( "dragmove", function( evt ) {
+		ok( "pageX" in evt, "checking for pageX property" );
+		ok( "pageY" in evt, "checking for pageY property" );
+	});
+
+	fireNative( $fixture[ 0 ], "dragmove" );
+	$fixture.unbind( "dragmove" ).remove();
+});
+
 test( "focusin using non-element targets", function() {
 	expect( 2 );
 
