Attributes: fix failing test for new return value

timmywil · timmywil · commit 5dc4616ca0fd · 2015-03-16T11:52:05.000-04:00
diff --git a/src/attributes/attr.js b/src/attributes/attr.js
@@ -28,7 +28,7 @@ jQuery.extend({
 
 		// don't get/set attributes on text, comment and attribute nodes
 		if ( !elem || nType === 3 || nType === 8 || nType === 2 ) {
-			return;
+			return null;
 		}
 
 		// Fallback to prop when attributes are not supported
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
@@ -377,8 +377,17 @@ test( "attr(String, Object)", function() {
 	jQuery.each( [ window, document, obj, "#firstp" ], function( i, elem ) {
 		var oldVal = elem.nonexisting,
 			$elem = jQuery( elem );
-		strictEqual( $elem.attr("nonexisting"), null, "attr works correctly for non existing attributes (bug #7500)." );
-		equal( $elem.attr( "nonexisting", "foo" ).attr("nonexisting"), "foo", "attr falls back to prop on unsupported arguments" );
+		// Falls back to prop, which returns undefined
+		strictEqual(
+			$elem.attr( "nonexisting" ),
+			typeof $elem[0].getAttribute === "undefined" ? undefined : null,
+			"attr works correctly for non existing attributes (bug #7500)."
+		);
+		equal(
+			$elem.attr( "nonexisting", "foo" ).attr( "nonexisting" ),
+			"foo",
+			"attr falls back to prop on unsupported arguments"
+		);
 		elem.nonexisting = oldVal;
 	});
 

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ jQuery.extend({`
`28`	`28`
`29`	`29`	`// don't get/set attributes on text, comment and attribute nodes`
`30`	`30`	`if ( !elem \|\| nType === 3 \|\| nType === 8 \|\| nType === 2 ) {`
`31`		`- return;`
	`31`	`+ return null;`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`// Fallback to prop when attributes are not supported`