Core: Standardize indexOf comparisons

gibson042 · gibson042 · commit 53aa87f3bf42 · 2015-01-10T23:47:01.000-05:00
not present: `< 0` present: `> -1` at index: `=== N` Closes gh-1984
diff --git a/src/ajax/jsonp.js b/src/ajax/jsonp.js
@@ -25,7 +25,8 @@ jQuery.ajaxPrefilter( "json jsonp", function( s, originalSettings, jqXHR ) {
 		jsonProp = s.jsonp !== false && ( rjsonp.test( s.url ) ?
 			"url" :
 			typeof s.data === "string" &&
-				!( s.contentType || "" ).indexOf("application/x-www-form-urlencoded") &&
+				( s.contentType || "" )
+					.indexOf("application/x-www-form-urlencoded") === 0 &&
 				rjsonp.test( s.data ) && "data"
 		);
 
diff --git a/src/ajax/load.js b/src/ajax/load.js
@@ -24,7 +24,7 @@ jQuery.fn.load = function( url, params, callback ) {
 		self = this,
 		off = url.indexOf(" ");
 
-	if ( off >= 0 ) {
+	if ( off > -1 ) {
 		selector = jQuery.trim( url.slice( off ) );
 		url = url.slice( 0, off );
 	}
diff --git a/src/attributes/classes.js b/src/attributes/classes.js
@@ -77,7 +77,7 @@ jQuery.fn.extend({
 					j = 0;
 					while ( (clazz = classes[j++]) ) {
 						// Remove *all* instances
-						while ( cur.indexOf( " " + clazz + " " ) >= 0 ) {
+						while ( cur.indexOf( " " + clazz + " " ) > -1 ) {
 							cur = cur.replace( " " + clazz + " ", " " );
 						}
 					}
@@ -150,7 +150,7 @@ jQuery.fn.extend({
 			l = this.length;
 		for ( ; i < l; i++ ) {
 			if ( this[i].nodeType === 1 &&
-				(" " + this[i].className + " ").replace(rclass, " ").indexOf( className ) >= 0 ) {
+				(" " + this[i].className + " ").replace(rclass, " ").indexOf( className ) > -1 ) {
 
 				return true;
 			}
diff --git a/src/attributes/val.js b/src/attributes/val.js
@@ -128,7 +128,7 @@ jQuery.extend({
 				while ( i-- ) {
 					option = options[ i ];
 					if ( (option.selected =
-							jQuery.inArray( jQuery.valHooks.option.get( option ), values ) >= 0) ) {
+							jQuery.inArray( jQuery.valHooks.option.get( option ), values ) > -1) ) {
 						optionSet = true;
 					}
 				}
@@ -148,7 +148,7 @@ jQuery.each([ "radio", "checkbox" ], function() {
 	jQuery.valHooks[ this ] = {
 		set: function( elem, value ) {
 			if ( jQuery.isArray( value ) ) {
-				return ( elem.checked = jQuery.inArray( jQuery(elem).val(), value ) >= 0 );
+				return ( elem.checked = jQuery.inArray( jQuery(elem).val(), value ) > -1 );
 			}
 		}
 	};
diff --git a/src/data.js b/src/data.js
@@ -160,7 +160,7 @@ jQuery.fn.extend({
 				// *... In the case of properties that might _actually_
 				// have dashes, we need to also store a copy of that
 				// unchanged property.
-				if ( key.indexOf("-") !== -1 && data !== undefined ) {
+				if ( key.indexOf("-") > -1 && data !== undefined ) {
 					dataUser.set( this, key, value );
 				}
 			});
diff --git a/src/event.js b/src/event.js
@@ -240,7 +240,7 @@ jQuery.event = {
 			return;
 		}
 
-		if ( type.indexOf(".") >= 0 ) {
+		if ( type.indexOf(".") > -1 ) {
 			// Namespaced trigger; create a regexp to match event type in handle()
 			namespaces = type.split(".");
 			type = namespaces.shift();
@@ -438,7 +438,7 @@ jQuery.event = {
 
 						if ( matches[ sel ] === undefined ) {
 							matches[ sel ] = handleObj.needsContext ?
-								jQuery( sel, this ).index( cur ) >= 0 :
+								jQuery( sel, this ).index( cur ) > -1 :
 								jQuery.find( sel, this, null, [ cur ] ).length;
 						}
 						if ( matches[ sel ] ) {
diff --git a/src/manipulation.js b/src/manipulation.js
@@ -248,7 +248,7 @@ jQuery.extend({
 
 			// #4087 - If origin and destination elements are the same, and this is
 			// that element, do not do anything
-			if ( selection && jQuery.inArray( elem, selection ) !== -1 ) {
+			if ( selection && jQuery.inArray( elem, selection ) > -1 ) {
 				continue;
 			}
 
diff --git a/src/traversing/findFilter.js b/src/traversing/findFilter.js
@@ -33,7 +33,7 @@ function winnow( elements, qualifier, not ) {
 	}
 
 	return jQuery.grep( elements, function( elem ) {
-		return ( indexOf.call( qualifier, elem ) >= 0 ) !== not;
+		return ( indexOf.call( qualifier, elem ) > -1 ) !== not;
 	});
 }
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ jQuery.fn.load = function( url, params, callback ) {`
`24`	`24`	`self = this,`
`25`	`25`	`off = url.indexOf(" ");`
`26`	`26`
`27`		`- if ( off >= 0 ) {`
	`27`	`+ if ( off > -1 ) {`
`28`	`28`	`selector = jQuery.trim( url.slice( off ) );`
`29`	`29`	`url = url.slice( 0, off );`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ jQuery.fn.extend({`
`77`	`77`	`j = 0;`
`78`	`78`	`while ( (clazz = classes[j++]) ) {`
`79`	`79`	`// Remove all instances`
`80`		`- while ( cur.indexOf( " " + clazz + " " ) >= 0 ) {`
	`80`	`+ while ( cur.indexOf( " " + clazz + " " ) > -1 ) {`
`81`	`81`	`cur = cur.replace( " " + clazz + " ", " " );`
`82`	`82`	`}`
`83`	`83`	`}`
`@@ -150,7 +150,7 @@ jQuery.fn.extend({`
`150`	`150`	`l = this.length;`
`151`	`151`	`for ( ; i < l; i++ ) {`
`152`	`152`	`if ( this[i].nodeType === 1 &&`
`153`		`- (" " + this[i].className + " ").replace(rclass, " ").indexOf( className ) >= 0 ) {`
	`153`	`+ (" " + this[i].className + " ").replace(rclass, " ").indexOf( className ) > -1 ) {`
`154`	`154`
`155`	`155`	`return true;`
`156`	`156`	`}`
Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ jQuery.extend({`
`128`	`128`	`while ( i-- ) {`
`129`	`129`	`option = options[ i ];`
`130`	`130`	`if ( (option.selected =`
`131`		`- jQuery.inArray( jQuery.valHooks.option.get( option ), values ) >= 0) ) {`
	`131`	`+ jQuery.inArray( jQuery.valHooks.option.get( option ), values ) > -1) ) {`
`132`	`132`	`optionSet = true;`
`133`	`133`	`}`
`134`	`134`	`}`
`@@ -148,7 +148,7 @@ jQuery.each([ "radio", "checkbox" ], function() {`
`148`	`148`	`jQuery.valHooks[ this ] = {`
`149`	`149`	`set: function( elem, value ) {`
`150`	`150`	`if ( jQuery.isArray( value ) ) {`
`151`		`- return ( elem.checked = jQuery.inArray( jQuery(elem).val(), value ) >= 0 );`
	`151`	`+ return ( elem.checked = jQuery.inArray( jQuery(elem).val(), value ) > -1 );`
`152`	`152`	`}`
`153`	`153`	`}`
`154`	`154`	`};`
Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ jQuery.fn.extend({`
`160`	`160`	`// *... In the case of properties that might _actually_`
`161`	`161`	`// have dashes, we need to also store a copy of that`
`162`	`162`	`// unchanged property.`
`163`		`- if ( key.indexOf("-") !== -1 && data !== undefined ) {`
	`163`	`+ if ( key.indexOf("-") > -1 && data !== undefined ) {`
`164`	`164`	`dataUser.set( this, key, value );`
`165`	`165`	`}`
`166`	`166`	`});`
Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ jQuery.extend({`
`248`	`248`
`249`	`249`	`// #4087 - If origin and destination elements are the same, and this is`
`250`	`250`	`// that element, do not do anything`
`251`		`- if ( selection && jQuery.inArray( elem, selection ) !== -1 ) {`
	`251`	`+ if ( selection && jQuery.inArray( elem, selection ) > -1 ) {`
`252`	`252`	`continue;`
`253`	`253`	`}`
`254`	`254`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ function winnow( elements, qualifier, not ) {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`return jQuery.grep( elements, function( elem ) {`
`36`		`- return ( indexOf.call( qualifier, elem ) >= 0 ) !== not;`
	`36`	`+ return ( indexOf.call( qualifier, elem ) > -1 ) !== not;`
`37`	`37`	`});`
`38`	`38`	`}`
`39`	`39`