Core: Change support.ownLast to support.ownFirst

mgol · mgol · commit 453738ab8560 · 2015-06-23T00:33:51.000+02:00
jQuery.support.ownLast was the only support test that was supposed to be false when it succeeded. It was confusing. Fixes gh-2406 Closes gh-2408
diff --git a/src/core.js b/src/core.js
@@ -248,7 +248,7 @@ jQuery.extend({
 
 		// Support: IE<9
 		// Handle iteration over inherited properties before own properties.
-		if ( support.ownLast ) {
+		if ( !support.ownFirst ) {
 			for ( key in obj ) {
 				return hasOwn.call( obj, key );
 			}
diff --git a/src/support.js b/src/support.js
@@ -12,7 +12,7 @@ var i;
 for ( i in jQuery( support ) ) {
 	break;
 }
-support.ownLast = i !== "0";
+support.ownFirst = i === "0";
 
 // Note: most support tests are defined in their respective modules.
 
diff --git a/test/unit/support.js b/test/unit/support.js
@@ -91,7 +91,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": true,
 			"optSelected": true,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": true,
 			"pixelPosition": true,
 			"radioValue": true,
@@ -123,7 +123,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": true,
 			"optSelected": false,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": true,
 			"pixelPosition": true,
 			"radioValue": false,
@@ -155,7 +155,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": true,
 			"optSelected": false,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": true,
 			"pixelPosition": true,
 			"radioValue": false,
@@ -187,7 +187,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": false,
 			"optDisabled": true,
 			"optSelected": false,
-			"ownLast": true,
+			"ownFirst": false,
 			"pixelMarginRight": true,
 			"pixelPosition": false,
 			"radioValue": false,
@@ -221,7 +221,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": true,
 			"optSelected": true,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": true,
 			"pixelPosition": true,
 			"radioValue": true,
@@ -253,7 +253,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": true,
 			"optSelected": true,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": true,
 			"pixelPosition": false,
 			"radioValue": true,
@@ -285,7 +285,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": true,
 			"optSelected": true,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": true,
 			"pixelPosition": false,
 			"radioValue": true,
@@ -317,7 +317,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": true,
 			"optSelected": true,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": true,
 			"pixelPosition": true,
 			"radioValue": true,
@@ -349,7 +349,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": true,
 			"optSelected": true,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": true,
 			"pixelPosition": false,
 			"radioValue": true,
@@ -381,7 +381,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": true,
 			"optSelected": true,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": true,
 			"pixelPosition": false,
 			"radioValue": true,
@@ -413,7 +413,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": true,
 			"optSelected": true,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": false,
 			"pixelPosition": false,
 			"radioValue": true,
@@ -445,7 +445,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
 			"opacity": true,
 			"optDisabled": false,
 			"optSelected": true,
-			"ownLast": false,
+			"ownFirst": true,
 			"pixelMarginRight": true,
 			"pixelPosition": false,
 			"radioValue": true,

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ jQuery.extend({`
`248`	`248`
`249`	`249`	`// Support: IE<9`
`250`	`250`	`// Handle iteration over inherited properties before own properties.`
`251`		`- if ( support.ownLast ) {`
	`251`	`+ if ( !support.ownFirst ) {`
`252`	`252`	`for ( key in obj ) {`
`253`	`253`	`return hasOwn.call( obj, key );`
`254`	`254`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ var i;`
`12`	`12`	`for ( i in jQuery( support ) ) {`
`13`	`13`	`break;`
`14`	`14`	`}`
`15`		`-support.ownLast = i !== "0";`
	`15`	`+support.ownFirst = i === "0";`
`16`	`16`
`17`	`17`	`// Note: most support tests are defined in their respective modules.`
`18`	`18`