Data: restore explicit data removal of private data in cleanData.

rwaldron · gibson042 · commit 332fd941b4ae · 2015-03-09T13:51:16.000-04:00
Fixes gh-2127 Closes gh-2132
diff --git a/src/manipulation.js b/src/manipulation.js
@@ -305,7 +305,7 @@ jQuery.extend({
 						}
 					}
 				}
-				delete data.events;
+				delete elem[ dataPriv.expando ];
 			}
 		}
 	}
diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
@@ -2047,6 +2047,23 @@ test( "jQuery.cleanData", function() {
 	}
 });
 
+test( "jQuery.cleanData eliminates all private data (gh-2127)", function() {
+	expect( 2 );
+
+	var div = jQuery( "<div/>" ).appendTo( "#qunit-fixture" );
+
+	jQuery._data( div[ 0 ], "gh-2127", "testing" );
+
+	ok( !jQuery.isEmptyObject( jQuery._data( div[ 0 ] ) ),  "Ensure some private data exists" );
+
+	div.remove();
+
+	ok( jQuery.isEmptyObject( jQuery._data( div[ 0 ] ) ),
+		"Private data is empty after node is removed" );
+
+	div.remove();
+});
+
 test( "jQuery.buildFragment - no plain-text caching (Bug #6779)", function() {
 
 	expect( 1 );

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ jQuery.extend({`
`305`	`305`	`}`
`306`	`306`	`}`
`307`	`307`	`}`
`308`		`- delete data.events;`
	`308`	`+ delete elem[ dataPriv.expando ];`
`309`	`309`	`}`
`310`	`310`	`}`
`311`	`311`	`}`