Core: Use window.setTimeout & friends instead of global equivalents

mgol · mgol · commit 219c7494938a · 2015-06-17T12:29:49.000+02:00
Fixes gh-2177
diff --git a/src/.jshintrc b/src/.jshintrc
@@ -14,10 +14,6 @@
 
 	"globals": {
 		"window": true,
-		"setTimeout": true,
-		"clearTimeout": true,
-		"setInterval": true,
-		"clearInterval": true,
 
 		"jQuery": true,
 		"define": true,
diff --git a/src/ajax.js b/src/ajax.js
@@ -2,14 +2,17 @@ define([
 	"./core",
 	"./var/document",
 	"./var/rnotwhite",
+	"./var/setTimeout",
+	"./var/clearTimeout",
 	"./ajax/var/location",
 	"./ajax/var/nonce",
 	"./ajax/var/rquery",
 	"./core/init",
 	"./ajax/parseJSON",
 	"./ajax/parseXML",
 	"./deferred"
-], function( jQuery, document, rnotwhite, location, nonce, rquery ) {
+], function( jQuery, document, rnotwhite, setTimeout, clearTimeout,
+	location, nonce, rquery ) {
 
 var
 	rhash = /#.*$/,
diff --git a/src/core/ready.js b/src/core/ready.js
@@ -1,8 +1,9 @@
 define([
 	"../core",
 	"../var/document",
+	"../var/setTimeout",
 	"../deferred"
-], function( jQuery, document ) {
+], function( jQuery, document, setTimeout ) {
 
 // The deferred used on DOM ready
 var readyList;
diff --git a/src/deferred.js b/src/deferred.js
@@ -1,8 +1,9 @@
 define([
 	"./core",
 	"./var/slice",
+	"./var/setTimeout",
 	"./callbacks"
-], function( jQuery, slice ) {
+], function( jQuery, slice, setTimeout ) {
 
 function Identity( v ) {
 	return v;
diff --git a/src/effects.js b/src/effects.js
@@ -2,6 +2,9 @@ define([
 	"./core",
 	"./var/document",
 	"./var/rcssNum",
+	"./var/setInterval",
+	"./var/clearInterval",
+	"./var/setTimeout",
 	"./css/var/cssExpand",
 	"./css/var/isHidden",
 	"./css/var/swap",
@@ -16,7 +19,8 @@ define([
 	"./manipulation",
 	"./css",
 	"./effects/Tween"
-], function( jQuery, document, rcssNum, cssExpand, isHidden, swap, adjustCSS, dataPriv, showHide ) {
+], function( jQuery, document, rcssNum, setInterval, clearInterval, setTimeout,
+	cssExpand, isHidden, swap, adjustCSS, dataPriv, showHide ) {
 
 var
 	fxNow, timerId,
diff --git a/src/queue/delay.js b/src/queue/delay.js
@@ -1,8 +1,10 @@
 define([
 	"../core",
+	"../var/setTimeout",
+	"../var/clearTimeout",
 	"../queue",
 	"../effects" // Delay is optional because of this dependency
-], function( jQuery ) {
+], function( jQuery, setTimeout, clearTimeout ) {
 
 // Based off of the plugin by Clint Helfers, with permission.
 // http://web.archive.org/web/20100324014747/http://blindsignals.com/index.php/2009/07/jquery-delay/
diff --git a/src/var/clearInterval.js b/src/var/clearInterval.js
@@ -0,0 +1,3 @@
+define(function() {
+	return window.clearInterval;
+});
diff --git a/src/var/clearTimeout.js b/src/var/clearTimeout.js
@@ -0,0 +1,3 @@
+define(function() {
+	return window.clearTimeout;
+});
diff --git a/src/var/setInterval.js b/src/var/setInterval.js
@@ -0,0 +1,3 @@
+define(function() {
+	return window.setInterval;
+});
diff --git a/src/var/setTimeout.js b/src/var/setTimeout.js
@@ -0,0 +1,3 @@
+define(function() {
+	return window.setTimeout;
+});

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+define(function() {`
	`2`	`+ return window.clearInterval;`
	`3`	`+});`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+define(function() {`
	`2`	`+ return window.clearTimeout;`
	`3`	`+});`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+define(function() {`
	`2`	`+ return window.setInterval;`
	`3`	`+});`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+define(function() {`
	`2`	`+ return window.setTimeout;`
	`3`	`+});`