url.parse problem with underscore in hostname #1360

galonsky · 2011-07-19T07:07:37Z

var url = require('url');
var obj = url.parse('http://bucket_name.s3.amazonaws.com/image.jpg');
console.log(obj);

on 0.4.6 (expected output):

{ protocol: 'http:',
  slashes: true,
  host: 'bucket_name.s3.amazonaws.com',
  hostname: '',
  pathname: '/image.jpg',
  href: 'http://bucket_name.s3.amazonaws.com/image.jpg' }

on 0.4.9, 0.5.0, 0.5.1:

{ protocol: 'http:',
  slashes: true,
  host: 'bucket',
  hostname: 'bucket',
  href: 'http://bucket/_name.s3.amazonaws.com/image.jpg',
  pathname: '/_name.s3.amazonaws.com/image.jpg' }

The text was updated successfully, but these errors were encountered:

bnoordhuis · 2011-07-19T11:35:00Z

Won't fix, sorry. Underscores are not allowed in hostnames.

isaacs · 2011-07-19T16:53:29Z

Hm, it seems like browsers actually allow this, and DNS lookups and everything work as expected. Also, it's a really tiny fix. Reopening.

isaacs · 2011-07-19T16:55:50Z

@bnoordhuis Care to review? isaacs/node@dcecfc5

bnoordhuis · 2011-07-19T18:18:29Z

@isaacs Good patch, wrong problem.

isaacs · 2011-07-19T18:31:09Z

@bnoordhuis Sure, but it's the problem we can actually solve. I don't know how to get the internet to stop supporting URL conventions that aren't allowed by the spec ;)

isaacs · 2011-07-19T18:41:32Z

For example, this site loads up fine with curl, Chrome, Safari, and node's HTTP client: http://foo_bar_blatz.izs.me/

bnoordhuis closed this as completed Jul 19, 2011

isaacs reopened this Jul 19, 2011

isaacs closed this as completed in dcecfc5 Jul 19, 2011

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

url.parse problem with underscore in hostname #1360

url.parse problem with underscore in hostname #1360

galonsky commented Jul 19, 2011

bnoordhuis commented Jul 19, 2011

isaacs commented Jul 19, 2011

isaacs commented Jul 19, 2011

bnoordhuis commented Jul 19, 2011

isaacs commented Jul 19, 2011

isaacs commented Jul 19, 2011

url.parse problem with underscore in hostname #1360

url.parse problem with underscore in hostname #1360

Comments

galonsky commented Jul 19, 2011

bnoordhuis commented Jul 19, 2011

isaacs commented Jul 19, 2011

isaacs commented Jul 19, 2011

bnoordhuis commented Jul 19, 2011

isaacs commented Jul 19, 2011

isaacs commented Jul 19, 2011