Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make options optional #42

Merged
merged 2 commits into from
May 8, 2024
Merged

feat: Make options optional #42

merged 2 commits into from
May 8, 2024

Conversation

devlzcode
Copy link
Contributor

Currently ValidationPipe requires options to be defined, forcing you to include a default e.g. {} if you don't have any options to specify.

Currently `ValidationPipe` requires `options` to be defined, forcing you to include a default e.g. `{}`  if you don't have any options to specify.
Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 482b43f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nest-lab/typeschema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Can you add a changeset via pnpm changeset for a patch as this should be seen as a bug fix?

@devlzcode devlzcode requested a review from jmcdo29 May 7, 2024 20:36
@jmcdo29 jmcdo29 merged commit b5fdced into jmcdo29:main May 8, 2024
1 of 5 checks passed
@devlzcode devlzcode deleted the patch-1 branch May 9, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants