Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoStore: Handle removal of "a" fields from calves #222

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

bartelink
Copy link
Collaborator

As of jet/equinox#401

  • non-Tip batches no longer bear an "a" field (as all writes must feed through Tip to guarantee correct arrival order for Indexer etc)
  • Indexer needs to be using same in order for it in turn to be able to guarantee same for the Notifier

Technically, the existing code would continue to work, but an out of date version would mean the Notifier cannot be trusted where the Index writes are not guaranteed to have been fed through tip.

Hence this intentional breaking change is to force people to upgrade Indexers to latest to match the Equinox behavior.

@bartelink bartelink marked this pull request as ready for review July 5, 2023 18:22
@bartelink bartelink merged commit ed27380 into master Jul 5, 2023
@bartelink bartelink deleted the dynamostore-tip-only branch July 5, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant