Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos Store #42

Merged
merged 66 commits into from
Dec 24, 2018
Merged

Cosmos Store #42

merged 66 commits into from
Dec 24, 2018

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Nov 1, 2018

Replaces #20, which hosted a former version of this work (with more legible history wrt early development phases).

Given anything that reflected a cross-cutting need was already merged early and the rebased upon, the earlier commits don't compile cleanly (hence doing a squash merge).

@bartelink bartelink requested a review from troykershaw November 1, 2018 18:09
@bartelink bartelink force-pushed the master branch 7 times, most recently from acb4e71 to 0228fd5 Compare November 6, 2018 00:37
@bartelink bartelink force-pushed the cosmos branch 9 times, most recently from a976fc6 to 8466ee1 Compare November 9, 2018 17:13
@bartelink
Copy link
Collaborator Author

That etag retrieval trickery was a lifesaver - thanks @jinglegit !
(I had been assigning to a temp with scope outside the callback, which drops the value by the time I tried to put it in the response)
Looking great now

@bartelink bartelink force-pushed the cosmos branch 4 times, most recently from 7d73fbe to c476d6a Compare November 17, 2018 09:17
@bartelink bartelink force-pushed the cosmos branch 2 times, most recently from 074ac6f to 277e470 Compare November 23, 2018 18:16
@bartelink bartelink force-pushed the cosmos branch 3 times, most recently from 3d966f1 to d33749d Compare November 27, 2018 10:46
@bartelink bartelink changed the title Cosmos Store (RC) Cosmos Store Dec 24, 2018
@bartelink bartelink force-pushed the cosmos branch 4 times, most recently from 898142a to 5ad250a Compare December 24, 2018 11:00
@bartelink
Copy link
Collaborator Author

bartelink commented Dec 24, 2018

@dongdongcai @enricosada @eulerfx @jinglegit @michaelliao5 @troykershaw Hold on to your posteriors, pipelines are smooth, this thing is going to master 👏

@bartelink bartelink merged commit e4a28f6 into master Dec 24, 2018
@bartelink bartelink deleted the cosmos branch December 24, 2018 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants