Merge pull request NativeScript#3815 from NativeScript/pete/fix-android-console

petekanev · web-flow · commit c8803f81471b · 2017-03-21T08:27:26.000+02:00
Always attach console implementation on android
diff --git a/tns-core-modules/globals/globals.ts b/tns-core-modules/globals/globals.ts
@@ -121,7 +121,11 @@ if ((<any>global).__snapshot) {
     registerOnGlobalContext("fetch", "fetch");
 }
 
-if (!(<any>global).console) {
+// check whether the 'android' namespace is exposed
+// if positive - the current device is an Android 
+// so a custom implementation of the global 'console' object is attached.
+// otherwise do nothing on iOS - the NS runtime provides a native 'console' functionality.
+if ((<any>global).android) {
     const consoleModule = require("console");
     (<any>global).console = new consoleModule.Console();
 }

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,11 @@ if ((<any>global).__snapshot) {`
`121`	`121`	`registerOnGlobalContext("fetch", "fetch");`
`122`	`122`	`}`
`123`	`123`
`124`		`-if (!(<any>global).console) {`
	`124`	`+// check whether the 'android' namespace is exposed`
	`125`	`+// if positive - the current device is an Android`
	`126`	`+// so a custom implementation of the global 'console' object is attached.`
	`127`	`+// otherwise do nothing on iOS - the NS runtime provides a native 'console' functionality.`
	`128`	`+if ((<any>global).android) {`
`125`	`129`	`const consoleModule = require("console");`
`126`	`130`	`(<any>global).console = new consoleModule.Console();`
`127`	`131`	`}`