Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict modal should not pop up if the substitution the player is trying to do resolves it #260

Open
Vazkii opened this issue Mar 15, 2023 · 1 comment
Labels
enhancement Nice little improvements or fixes for things that already exist priority: low Tasks that can wait

Comments

@Vazkii
Copy link

Vazkii commented Mar 15, 2023

E.g. Replacing an Ultima with an Ultima should not prompt the conflict modal, as the the end result of that replacement is non-conflicting

@jedmund jedmund added priority: low Tasks that can wait enhancement Nice little improvements or fixes for things that already exist labels Mar 17, 2023
@jedmund
Copy link
Owner

jedmund commented Mar 17, 2023

This is actually a good call. This might be a little bit more complicated/annoying to implement but I will get to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Nice little improvements or fixes for things that already exist priority: low Tasks that can wait
Projects
None yet
Development

No branches or pull requests

2 participants