Disallow platform aliases for get_topology_desc #25143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2810
reviewed
Nov 27, 2024
jax/_src/xla_bridge.py
Outdated
| @@ -1250,10 +1250,15 @@ def using_pjrt_c_api(backend=None): | |||
|
|
|||
| def make_pjrt_topology(platform: str, topology_name='', **kwargs): | |||
| _discover_and_register_pjrt_plugins() | |||
| actual_platform = canonicalize_platform(platform) | |||
| if not platform in expand_platform_alias(platform): | |||
There was a problem hiding this comment.
if platform not in expand_platform_alias(platform):. Avoid using if not ... in ... pattern.
jaro-sevcik
force-pushed
the
disallow-platform-alias-for-get-topology-desc
branch
from
fd41528
to
288cffa
Compare
yashk2810
approved these changes
Nov 27, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.