fix(core): Observable splice index > length (NativeScript#8900)

farfromrefug · web-flow · commit 65b1cdbae0a9 · 2020-09-27T09:20:52.000-07:00
* fix for splice index &gt; length

In javascript you can call splice with an index &gt; length. The result is a push.
But when you do that ObservableArray index will be wrong and thus user logic will fail.
Example:
```ts
// obsarray = [0];
obsarray.splice(2, 0, 1);
// this works, the inner array is now [0,1]
// however 'change' is called with index = 2
// when the use tries to do obsarray.getItem(eventData.index) -&gt; crash
```

* fix to handle delete too
diff --git a/packages/core/data/observable-array/index.ts b/packages/core/data/observable-array/index.ts
@@ -246,7 +246,7 @@ export class ObservableArray<T> extends Observable {
 			eventName: CHANGE,
 			object: this,
 			action: ChangeType.Splice,
-			index: start,
+			index: Math.min(start, this._array.length-1),
 			removed: result,
 			addedCount: this._array.length + result.length - length,
 		});
