Yeah, I agree that this is a good idea, since it seems UTF-8 is at least how GHC reads files (source). We can do this on all platforms and allow users to disable it with a command-line option.

but just adding

        hSetEncoding stdout utf8
        readUTF8File fileName >>= putStr

doesn't help with atom, cc @lierdakil

That's probably because ide-haskell uses stylish-haskell as filter, i.e. source is passed on stdin instead of file. Try to hSetEncoding stdin utf8.

@lierdakil no effect and no error messages

Another approach could be using the bytestring library, reading stdin as raw ByteString and using T.unpack . Data.Text.Encoding.decodeUtf8 to convert it into a String. It's a bit more hassle but it would do the job, I think.

@Heather, I think you might be hacking on the wrong part of stylish-haskell there... lines 52-55 of src/Main.hs have to do with dumping default config, not actual "stylishing".

You might want to do this in main before call to stylishHaskell (should work) or in file (might work)

Minimal example:

main :: IO ()
main = do
    mapM_ (`hSetEncoding` utf8) [stdin, stdout]
    cmdArgs stylishArgs >>= stylishHaskell

@jaspervdj seems like helped #109

@jaspervdj btw, it doesn't work with CPP things alike #if MIN_VERSION_Win32(2,3,1) - is it known issue?

Yes @Heather, CPP is impossible to parse in some cases, so stylish-haskell doesn't try.

@Heather I've added an --utf8 flag which should do the job in 90f18cb, which is on the master branch. Could you try that out on Windows? I hope there's some way to tell atom that it should use the --utf8 flag.

That would be my job... Sigh. I'll have to check version of stylish-haskell
now as well.
1 июня 2016 г. 9:41 PM пользователь "Jasper Van der Jeugt" <
[email protected]> написал:

@Heather https://github.com/Heather I've added an --utf8 flag which
should do the job in 90f18cb
90f18cb,
which is on the master branch. Could you try that out on Windows? I hope
there's some way to tell atom that it should use the --utf8 flag.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#108 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AG8EZn3_kWc5sbXgd-NtvcUK_OS6IFdOks5qHdJAgaJpZM4IoO1q
.

@jaspervdj sure I can test it some later, it doesn't use change I used to add so result could be different

+readUTF8File :: FilePath -> IO String
 +readUTF8File fp = do
 +    content <- B.readFile fp
 +    let utf = decodeUtf8 content
 +    return (T.unpack utf)

@lierdakil oh, in that case I can make it the default. It shouldn't hurt.

@Heather That code is not used if you're just using stylish-haskell as a unix filter (which I believe Atom is doing), so it should not matter.

If you could make it default, that would be great. Thanks.
1 июня 2016 г. 11:02 PM пользователь "Jasper Van der Jeugt" <
[email protected]> написал:

@lierdakil https://github.com/lierdakil oh, in that case I can make it
the default. It shouldn't hurt.

@Heather https://github.com/heather That code is not used if you're
just using stylish-haskell as a unix filter (which I believe Atom is
doing), so it should not matter.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#108 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AG8EZtFQLeOrPhgi66qKiYmJpiJLveBaks5qHeVBgaJpZM4IoO1q
.

I've uploaded stylish-haskell-0.5.17.0, which sets stdin/stdout encoding to UTF-8 by default. That should fix this issue. Feel free to re-open if it doesn't.