Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jashkenas/underscore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.1.3
Choose a base ref
...
head repository: jashkenas/underscore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.1.4
Choose a head ref
  • 18 commits
  • 10 files changed
  • 3 contributors

Commits on Dec 3, 2010

  1. Adding a note about the _.each change.

    @jashkenas
    jashkenas committed Dec 3, 2010
    Configuration menu
    Copy the full SHA
    3b916a2 View commit details
    Browse the repository at this point in the history

  2. Fix _.isEquals() for wrapped objects 

    This caught me out when writing some unit tests that use _.isEquals().
They were all passing even though I knew they shouldn't be, and I
realised I was checking equality with a wrapped object that I'd
forgotten to unwrap.
    @jasondavies
    jasondavies committed Dec 3, 2010
    Configuration menu
    Copy the full SHA
    2120b27 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/documentcloud/underscore

    @jasondavies
    jasondavies committed Dec 3, 2010
    Configuration menu
    Copy the full SHA
    85f1c77 View commit details
    Browse the repository at this point in the history

  4. merging in jasondavies isEqual patch for wrapped objects.

    @jashkenas
    jashkenas committed Dec 3, 2010
    Configuration menu
    Copy the full SHA
    70d760f View commit details
    Browse the repository at this point in the history

  5. period.

    @jashkenas
    jashkenas committed Dec 3, 2010
    Configuration menu
    Copy the full SHA
    e63f44f View commit details
    Browse the repository at this point in the history

  6. Access the _wrapped property directly instead of calling value() … 

    …when unwrapping wrapped objects in `isEqual()`
    @ryantenney
    ryantenney committed Dec 3, 2010
    Configuration menu
    Copy the full SHA
    ebe0cc6 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2010

  1. Improve compliance with Array methods in ES5 when passed a null value… 

    …. (ES5 Array methods treat `null` like `[]`)
    @ryantenney
    ryantenney committed Dec 7, 2010
    Configuration menu
    Copy the full SHA
    8f86e3e View commit details
    Browse the repository at this point in the history

  2. Improve compliance with Array methods in ES5 when passed a null value… 

    …. (ES5 Array methods treat `null` like `[]`)
    @ryantenney
    ryantenney committed Dec 7, 2010
    Configuration menu
    Copy the full SHA
    cdcf18b View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2010

  1. Merge branch 'master' of http://github.com/ryantenney/underscore

    @jashkenas
    jashkenas committed Dec 13, 2010
    Configuration menu
    Copy the full SHA
    9a9f2a8 View commit details
    Browse the repository at this point in the history

  2. Issue #79. Correctly setting 'this' in '_.wrap'

    @jashkenas
    jashkenas committed Dec 13, 2010
    Configuration menu
    Copy the full SHA
    3a113d2 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2010

  1. Issue #68. Adding _.sortedIndexOf

    @jashkenas
    jashkenas committed Dec 17, 2010
    Configuration menu
    Copy the full SHA
    8c2570b View commit details
    Browse the repository at this point in the history

  2. Rework of #68, to use a flag to indexOf, instead of a separate function.

    @jashkenas
    jashkenas committed Dec 17, 2010
    Configuration menu
    Copy the full SHA
    d2d6cfe View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2010

  1. switching to canonical isNaN

    @jashkenas
    jashkenas committed Dec 20, 2010
    Configuration menu
    Copy the full SHA
    2dff99d View commit details
    Browse the repository at this point in the history

  2. updating _.isNaN comment doc.

    @jashkenas
    jashkenas committed Dec 20, 2010
    Configuration menu
    Copy the full SHA
    422d354 View commit details
    Browse the repository at this point in the history

  3. Issue #83 ... typo.

    @jashkenas
    jashkenas committed Dec 20, 2010
    Configuration menu
    Copy the full SHA
    a890afe View commit details
    Browse the repository at this point in the history

  4. safer but slower toArray fallback, in light of .callee throwing in st… 

    …rict mode.
    @jashkenas
    jashkenas committed Dec 20, 2010
    Configuration menu
    Copy the full SHA
    b3a373a View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2010

  1. trying to avoid obj.callee (strict mode)

    @jashkenas
    jashkenas committed Dec 21, 2010
    Configuration menu
    Copy the full SHA
    fad002d View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2011

  1. Underscore 1.1.4 is on the books.

    @jashkenas
    jashkenas committed Jan 9, 2011
    Configuration menu
    Copy the full SHA
    f03d5fa View commit details
    Browse the repository at this point in the history
Loading