Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of penalty parameter ranges? #161

Open
JohannesWiesner opened this issue Jan 16, 2023 · 1 comment
Open

Documentation of penalty parameter ranges? #161

JohannesWiesner opened this issue Jan 16, 2023 · 1 comment

Comments

@JohannesWiesner
Copy link
Contributor

Just noted, that for cca_zoo.SCCA_PMD the penalty parameters must be within the range 0-1 (as discussed in this thread with the idea of penalty ranges from 0-1 being more "sklearn-ish" and also to stick to the original R-implementation of the authors) but for models like cca_zoo.GRCCA it can be 0-inf. Maybe it would be a good idea to already describe the penalty ranges in the documentation? Also noted that cca_zoo.SCCA_PMD throws an error when providing values for c > 1 which is nice. However, this could conversely lead users to think that this is some sort of default range for other Sparse CCA classes?

@JohannesWiesner JohannesWiesner changed the title Uniform definition of penalty parameter ranges? Documentation of penalty parameter ranges? Jan 16, 2023
@jameschapman19
Copy link
Owner

agree with these comments will adjust when I get the chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants