You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just noted, that for cca_zoo.SCCA_PMD the penalty parameters must be within the range 0-1 (as discussed in this thread with the idea of penalty ranges from 0-1 being more "sklearn-ish" and also to stick to the original R-implementation of the authors) but for models like cca_zoo.GRCCA it can be 0-inf. Maybe it would be a good idea to already describe the penalty ranges in the documentation? Also noted that cca_zoo.SCCA_PMD throws an error when providing values for c > 1 which is nice. However, this could conversely lead users to think that this is some sort of default range for other Sparse CCA classes?
The text was updated successfully, but these errors were encountered:
JohannesWiesner
changed the title
Uniform definition of penalty parameter ranges?
Documentation of penalty parameter ranges?
Jan 16, 2023
Just noted, that for
cca_zoo.SCCA_PMD
the penalty parameters must be within the range0-1
(as discussed in this thread with the idea of penalty ranges from 0-1 being more "sklearn-ish" and also to stick to the original R-implementation of the authors) but for models likecca_zoo.GRCCA
it can be0-inf
. Maybe it would be a good idea to already describe the penalty ranges in the documentation? Also noted thatcca_zoo.SCCA_PMD
throws an error when providing values forc > 1
which is nice. However, this could conversely lead users to think that this is some sort of default range for other Sparse CCA classes?The text was updated successfully, but these errors were encountered: