13.0 pos logout cleanup #1379
Merged
13.0 pos logout cleanup #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelizariev
reviewed
Mar 1, 2021
There was a problem hiding this comment.
Я не уверен, что модуль pos_pin удалять нужно. Из зависимостей - да, но не сам модуль. Можно ли без него сделать запрос пина с проверкой группы доступа?
Technical module, that allows to managers confirm an action by entering his pin code.
It addssudo_custommethod to be used in other modules. Unlike the build-insudofunction, the module allows
specify access group that user must have to confirm an action.
|
Выделю в отдельный ПР тогда, там подробнее изучу |
Closed
|
I approve to merge it now |
|
Approved by @trojikman
|
yelizariev
reviewed
Mar 2, 2021
| @@ -1,3 +1,8 @@ | |||
| `2.0.0` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.