doc: fix 'dhparam' description of tls.createServer #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@silverwind Why was a sentence of the invalid case removed? I wrote it in order to notify users of the case in https://github.com/iojs/io.js/blob/v1.x/src/node_crypto.cc#L738-L741 and had an error test in https://github.com/iojs/io.js/blob/v1.x/test/parallel/test-tls-dhe.js#L78-L81 . |
|
Oh, right. It shouldn't be deleted, just rephrased to not refer to a file. |
silverwind
force-pushed
the
doc-dhparam
branch
from
00c63ce to
00c452f
Compare
|
Updated. |
shigeki
pushed a commit
that referenced
this pull request
Feb 26, 2015
fixes #958 Fixes: #958 PR-URL: #968 Reviewed-By: Shigeki Ohtsu <[email protected]>
|
Thank you very much. Landed in c5050d8 . |
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified again that it works with both string and buffer types.
fixes #958
R: @shigeki