Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove gyp test directory #1350

Closed
wants to merge 1 commit into from
Closed

tools: remove gyp test directory #1350

wants to merge 1 commit into from

Conversation

shigeki
Copy link
Contributor

@shigeki shigeki commented Apr 6, 2015

gyp tests are not performed in iojs and it's size about 8M bytes. We can check gyp tests outside of iojs and reduce the size of the repository by removing them.
cf. #1325 (comment) ,

tools: remove gyp test directory
13f3fb7 
gyp tests are not performed in iojs and it's size about 8M bytes. We
can check gyp tests outside of iojs and reduce the size of the
repository by removing them.
@jbergstroem
Copy link
Member

LGTM

@jbergstroem
Copy link
Member

Replying to @Fishrock123's comment in #1325:

I think it was discussed previously that the v8 suite should be untracked..

The v8 directories (and others) are removed when creating tarballs. Since gyp introduced test with this commit I'm more reluctant to have it stay. I guess the unfortunate action was letting it in to the git tree since we now grown the git tree -- I personally don't know a way of removing stuff without rewriting commit history.

@Fishrock123
Copy link
Contributor

I guess the unfortunate action was letting it in to the git tree since we now grown the git tree -- I personally don't know a way of removing stuff without rewriting commit history.

This is something I wish git had an option to disable bits of past history for, even if it technically break things at specific commits without downloading/getting extra repo data.

It gets really bad if you ever deal with already-compressed data in git. (jpegs, tgz, etc)

@jbergstroem jbergstroem mentioned this pull request Apr 6, 2015
Closed
@Fishrock123
Copy link
Contributor

LGTM also

@rvagg
Copy link
Member

rvagg commented Apr 6, 2015

lgtm

shigeki pushed a commit to shigeki/node that referenced this pull request Apr 6, 2015
tools: remove gyp test directory
644ece1 
gyp tests are not performed in iojs and it's size about 8M bytes. We
can check gyp tests outside of iojs and reduce the size of the
repository by removing them.

PR-URL: nodejs#1350
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@shigeki
Copy link
Contributor Author

shigeki commented Apr 6, 2015

Thanks. Landed in 644ece1 .

@shigeki shigeki closed this Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shigeki @jbergstroem @Fishrock123 @rvagg